Merged
Conversation
Collaborator
|
@teunbrand Thanks for the PR! When are you planning on the ggplot2 release? I wonder if the CRAN releases will have to be coordinated -- that could make things more complicated. Would it make sense to make the test conditional on ggplot2 version? |
Contributor
Author
I expect in 3 weeks or later. We're now tinkering to prevent unnecessary revdep failures, but we undoubtedly can't prevent all and have to give 2 weeks notice to maintainers.
That is probably not necessary. The change in this PR would work with both the old and the new. Once shiny fully depends on ggplot2 >= 4.0.0 you can remove the |
wch
reviewed
Jun 9, 2025
wch
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Winston & team,
We're preparing a new release of ggplot2 and found a reverse dependency failure for shiny.
Because we're switching from S7 to S3 in this release, an S3 method in your tests needed a small adjustment to work for the S7 class.
Best wishes,
Teun